Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc server to ruby 3 #4296

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefandecimelli
Copy link

Description

Updates the ruby version for the doc server in order to fix dependency issue.
(pull request recreated for proper commit signing)

Addressed Issue

fixes: #4247

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: Stefan Decimelli <[email protected]>
@stefandecimelli stefandecimelli force-pushed the 4247-ruby-version-update branch from 9ff1956 to ae7da0a Compare October 23, 2024 18:12
@stefandecimelli stefandecimelli changed the title update to ruby 3 Update doc server to ruby 3 Oct 23, 2024
@nscuro
Copy link
Member

nscuro commented Oct 23, 2024

Do we know if this will work with GitHub Pages? They still list Jekyll v3.x here: https://pages.github.com/versions/

It seems like in order to use newer versions of Jekyll, you need to build and publish the site via GitHub Actions: https://www.moncefbelyamani.com/making-github-pages-work-with-latest-jekyll/

Signed-off-by: Stefan Decimelli <[email protected]>
@stefandecimelli
Copy link
Author

stefandecimelli commented Oct 30, 2024

Do we know if this will work with GitHub Pages? They still list Jekyll v3.x here: https://pages.github.com/versions/

It seems like in order to use newer versions of Jekyll, you need to build and publish the site via GitHub Actions: https://www.moncefbelyamani.com/making-github-pages-work-with-latest-jekyll/

It seems we are at a bit of an impasse here.
The highest 3.x tag for jekyll is 3.8 / 3.8.6, which still uses Ruby 2. (https://hub.docker.com/r/jekyll/jekyll/tags).

The next subsequent version tag is 4.x with only 4.2.2 using Ruby 3, which Github has not added support for according to their version doc.

According to this comment the maintainer for the jekyll docker images is no longer active.

This PR will need to wait until GitHub updates their supported Jekyll version to 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The jekyll image specified in the docs is incompatible with
2 participants