-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Fix that Emails render all symbols right #4141
Feat: Fix that Emails render all symbols right #4141
Conversation
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
src/main/java/org/dependencytrack/notification/publisher/SendMailPublisher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Could you add a test to SendMailPublisherTest
that includes special characters, to verify the escaping works as expected?
Signed-off-by: Thomas Schauer-Köckeis <[email protected]>
I don't know why the test fails, locally it runs completely fine. |
Maybe flaky, haven't seen that test fail before but could always be. Restarted the test workflow. |
Description
Fixes that emails can render all symbols right:
Addressed Issue
Fixes #4140
Additional Details
Changed MIME Type to include chaset=utf-8, so it uses utf-8 and not just ASCII.
Unescapse the content, so e.g. & does not convert to & and other such things.
Checklist
- [ ] This PR implements an enhancement, and I have provided tests to verify that it works as intended- [ ] This PR introduces changes to the database model, and I have added corresponding update logic- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly