Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date format to support offset in nuget analyser #3736

Merged

Conversation

sahibamittal
Copy link
Contributor

@sahibamittal sahibamittal commented May 20, 2024

Description

Nuget Analyzer has list of two supported SimpleDateFormat which are allowed for parsing the dates being received from the repository, based on limited test data.

Now, as seen in logs, below date format is also received from the nugget repo. This date has offset dateTime and needs to be added to the list of supported formats in order to avoid the ParseException.

Date example: 1900-01-01T00:00:00+00:00
Format needed: yyyy-MM-dd'T'HH:mm:ss

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal force-pushed the fix-offset-date-time-nuget-analyzer branch from fc0bfd0 to 09d7465 Compare May 20, 2024 09:06
@nscuro
Copy link
Member

nscuro commented May 20, 2024

Thanks @sahibamittal! Could you please rebase with master again?

The test suite failed due to #3737, which has now been resolved via #3738.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9ac6995) 21640 16399 75.78%
Head commit (a61c3d4) 21640 (+0) 16399 (+0) 75.78% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3736) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro added the enhancement New feature or request label May 20, 2024
@nscuro nscuro added this to the 4.12 milestone May 20, 2024
@nscuro nscuro merged commit 58cfed3 into DependencyTrack:master May 20, 2024
12 checks passed
@sahibamittal sahibamittal deleted the fix-offset-date-time-nuget-analyzer branch May 20, 2024 21:14
@nscuro nscuro added defect Something isn't working and removed enhancement New feature or request labels Jun 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants