Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivy tweaks #3630

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Trivy tweaks #3630

merged 3 commits into from
Apr 20, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Apr 20, 2024

Description

Updates the Trivy documentation with more instructions, as well as known limitations.

Also changes the default Trivy base URL from http://localhost:8081 to null, to avoid confusion.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

nscuro added 3 commits April 20, 2024 19:56
…8081`

Most users are deploying Dependency-Track in container environments, where `localhost` will never work for an external Trivy server. Better to not include a default at all instead of a misleading / broken one.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added documentation Improvements or additions to documentation integration/trivy Related to the Trivy integration labels Apr 20, 2024
@nscuro nscuro added this to the 4.11 milestone Apr 20, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4e9bab5) 21979 16459 74.89%
Head commit (5bf8eda) 21979 (+0) 16459 (+0) 74.89% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3630) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro merged commit 8e44ee5 into DependencyTrack:master Apr 20, 2024
12 checks passed
@nscuro nscuro deleted the trivy-tweaks branch April 20, 2024 18:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation integration/trivy Related to the Trivy integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant