Extend length of PURL
and PURLCOORDINATES
columns from 255 to 786
#3560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends length of
PURL
andPURLCOORDINATES
columns from 255 to 786.Because PURLs are also used to populate the
TARGET
column ofCOMPONENTANALYSISCACHE
, that column's length also has to be extended.Addressed Issue
Fixes #2076
Additional Details
The length of 786 was chosen as a middle ground between the current 255 and the more optimal 1024. Mainly because MSSQL versions before 2016 have a maximum index key length of 900 (#2076 (comment)).
We don't want to break anything in that respect at the moment, and 786 should still be plenty of space.
Running DT with MySQL already takes manual effort, due to MySQL's even more restrictive key length limits (#271 (comment)). We're not making it worse by increasing the column length even more.
Tested upgrade from DT v4.10.1 to v4.11.0-SNAPSHOT for:
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly