Perform License Resolution On Name Field During SBOM Import #3555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On import of SBOMs with SPDX compliant license ID in the
name
field and with noid
field, license resolution should first occur against standard licenses.If none found, only then should license resolution occur against custom licenses.
Addressed Issue
Fixes #3433
Additional Details
On SBOM import, if the license candidate/license option did not have an
id
field and only aname
field, we were assuming the license to lookup would be a custom license (whereas in fact, thename
field could contain a standard license ID and not a custom one)In this change, during BOM upload, if license does not have an
id
, then we callqm.getLicense()
with thename
field first. If it returns no results, only then do we callqm.getCustomLicense()
Sample SBOM used for testing is attached to this PR:
tiny-bom.json
Please do let me know if I am doing anything blatantly wrong :)
Checklist