Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VulnDB parser being unable to import vulnerability records when 'nvd_additional_information' is empty #3437

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

lukas-braune
Copy link
Contributor

@lukas-braune lukas-braune commented Feb 5, 2024

Without this condition, parsing the nvd_additional_information field given as an empty array would fail. This fixes #3436.

Description

A condition was added to DT's VulnDB parser that checks whether the nvd_additional_information field of a vulnerability record is empty and skips its processing. Otherwise, the parsing would fail as described in #3436.

Addressed Issue

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Without this condition, parsing 'nvd_additional_information' as an empty array would fail. This fixes DependencyTrack#3436.

Signed-off-by: Lukas Braune <[email protected]>
@nscuro nscuro added defect Something isn't working integration/vulndb Related to the VulnDB integration labels Feb 5, 2024
@nscuro nscuro added this to the 4.11 milestone Feb 5, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukas-braune!

@nscuro nscuro merged commit 113279c into DependencyTrack:master Feb 5, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working integration/vulndb Related to the VulnDB integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VulnDB parser fails to import vulnerability files from 'vulndb-data-mirror'
2 participants