-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhook alert token and new user alerts #3275
Conversation
Signed-off-by: Marlon Pina Tojal <[email protected]>
Signed-off-by: Marlon Pina Tojal <[email protected]>
@nscuro couldn't find where is the documentation for these alerts, can you point me to the right place |
Signed-off-by: Marlon Pina Tojal <[email protected]>
Signed-off-by: Marlon Pina Tojal <[email protected]>
probably here: https://docs.dependencytrack.org/integrations/notifications/#outbound-webhooks |
Signed-off-by: Marlon Pina Tojal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One major caveat here is that users created via auto-provisioning are not captured. As this is happening in Alpine, there's no easy way for DT to detect it:
- Users created for OIDC: https://github.com/stevespringett/Alpine/blob/5727c590c59881d6e46630839e2a8a9dcadcbf4f/alpine-server/src/main/java/alpine/server/auth/OidcAuthenticationService.java#L228-L241
- Users created for LDAP: https://github.com/stevespringett/Alpine/blob/5727c590c59881d6e46630839e2a8a9dcadcbf4f/alpine-server/src/main/java/alpine/server/auth/LdapAuthenticationService.java#L117-L121
src/main/java/org/dependencytrack/notification/publisher/AbstractWebhookPublisher.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marlon Pina Tojal <[email protected]>
Signed-off-by: Marlon Pina Tojal <[email protected]>
Signed-off-by: Marlon Pina Tojal <[email protected]>
Description
This PR adds two new notification types (user_created and user_deleted) and the possibility of setting a token on the webhook alert
Addressed Issue
Closes #3255
Closes #3256
Checklist