Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for github component sources #3112

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

jadyndev
Copy link
Contributor

@jadyndev jadyndev commented Oct 20, 2023

Description

Add support for GitHub as a component source.

Additional Details

  • Currently this feature can't be configured to use a specific GitHub account.
  • The according repository (github.com) is added by default
  • UI for new repositories is not added

Addressed Issue

Addresses #1840
Closes #1825

Checklist

  • I have read and understand the contributing guidelines
    - [ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
    - [ ] This PR introduces changes to the database model, and I have added corresponding update logic
    - [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@jadyndev jadyndev force-pushed the jadyn/github-support branch 3 times, most recently from e4e364e to ce1f61d Compare October 20, 2023 16:23
@nscuro nscuro added this to the 4.10 milestone Oct 26, 2023
@nscuro
Copy link
Member

nscuro commented Nov 5, 2023

Thanks for the PR @jadyndev! Looks good so far, but a few tests are failing. Could you look into fixing those so we can merge this?

@jadyndev jadyndev force-pushed the jadyn/github-support branch 2 times, most recently from 2ac3b7e to 61b47b0 Compare November 10, 2023 17:44
@jadyndev jadyndev force-pushed the jadyn/github-support branch from 61b47b0 to a7f9216 Compare November 10, 2023 20:15
@jadyndev
Copy link
Contributor Author

Thanks for the PR @jadyndev! Looks good so far, but a few tests are failing. Could you look into fixing those so we can merge this?

I fixed the issues.

@nscuro nscuro merged commit 47c2e85 into DependencyTrack:master Nov 13, 2023
7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub as repository
2 participants