Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added transient List of ProjectVersions and set Metrics in Project #2581

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

walterdeboer
Copy link

@walterdeboer walterdeboer commented Mar 9, 2023

Description

Added transient List of ProjectVersions and set Metrics in Project to minimize the number of round trips a client needs to make

Addressed Issue

fixes: DependencyTrack/frontend#397

Additional Details

Used by: DependencyTrack/frontend#440

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Mar 9, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2581.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2581.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@walterdeboer walterdeboer force-pushed the feature/frontend-397 branch 5 times, most recently from 211576d to ed0d930 Compare March 12, 2023 08:57
@nscuro nscuro added this to the 4.9 milestone Apr 18, 2023
@msymons
Copy link
Member

msymons commented Apr 27, 2023

@walterdeboer, following the release of v4.8.0, this PR now has conflicts that need to be resolved before it can be merged. Please can you fix things? Then the PR can be reviewed.

… minimize the number of round trips a client needs to make

Signed-off-by: Walter de Boer <[email protected]>
@walterdeboer walterdeboer force-pushed the feature/frontend-397 branch from ed0d930 to c02fe38 Compare April 28, 2023 05:35
@melba-lopez
Copy link
Contributor

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2581.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/dependency-track/2581.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@nscuro @walterdeboer I'm not familiar with how the sonatype lift feature works. If the bot does not "autoresolve" by marking it outdated, does that mean its not addressed? Or would we expect it to restate the same issue after a new commit is made (if its not fixed)? This is my only question/concern for this PR.

@walterdeboer
Copy link
Author

@melba-lopez
To my understanding Sonatye Lift checks the code each time changes are pushed. So it will restate the same issue after a new commit is made if its not fixed

Thanks for the review!

@walterdeboer walterdeboer force-pushed the feature/frontend-397 branch 3 times, most recently from 32284b4 to d4cf4e8 Compare June 27, 2023 19:19
@walterdeboer walterdeboer requested a review from nscuro June 27, 2023 19:36
@walterdeboer walterdeboer marked this pull request as draft June 27, 2023 20:08
@walterdeboer walterdeboer force-pushed the feature/frontend-397 branch from d4cf4e8 to 8580c05 Compare June 27, 2023 21:02
@walterdeboer walterdeboer marked this pull request as ready for review June 27, 2023 21:05
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@nscuro nscuro merged commit d73b236 into DependencyTrack:master Jun 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project page version dropdown displays only 10 options
4 participants