-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NullPointerException
when updating a project
#2319
Fix NullPointerException
when updating a project
#2319
Conversation
Fixes the `NullPointerException` which occurs when updating a project where `project.isActive() == null` Signed-off-by: RBickert <[email protected]>
if you run a project wide search for |
Signed-off-by: RBickert <[email protected]>
Thanks for noticing, I think that every |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rbt-mm and @valentijnscholten! 🙌
) * Fix `NullPointerException` in ProjectQueryManager Fixes the `NullPointerException` which occurs when updating a project where `project.isActive() == null` Signed-off-by: RBickert <[email protected]> * Prevent NullPointerException in NotificationRouter Signed-off-by: RBickert <[email protected]> Signed-off-by: RBickert <[email protected]> Signed-off-by: mulder999 <[email protected]>
@nscuro This started occurring out of nowhere on my instances. There might be some codepaths in 4.7.0 that somehow set a null value in the database. So a onetime SQL query to fix those values might not be a structural solution. Any chance we can get a 4.7.1? I can whip up a PR with backport + release notes. |
@valentijnscholten We're looking into bundling multiple of such annoyances into a bugfix release right now. I've seen a few similar requests now on other issues so I think it makes sense to backport more than just this. |
Any update on a patch release to help fix this? |
) * Fix `NullPointerException` in ProjectQueryManager Fixes the `NullPointerException` which occurs when updating a project where `project.isActive() == null` Signed-off-by: RBickert <[email protected]> * Prevent NullPointerException in NotificationRouter Signed-off-by: RBickert <[email protected]> Signed-off-by: RBickert <[email protected]>
We backported this to 4.7.1, which was just released. |
Thank you very much ❤️ |
) * Fix `NullPointerException` in ProjectQueryManager Fixes the `NullPointerException` which occurs when updating a project where `project.isActive() == null` Signed-off-by: RBickert <[email protected]> * Prevent NullPointerException in NotificationRouter Signed-off-by: RBickert <[email protected]> Signed-off-by: RBickert <[email protected]>
Description
If the active status of a project is
null
and someone tries to update that project, aNullPointerException
will be thrown because that case is currently not handled.This PR checks if the active status of a project is
null
when trying to update the project, and handles the case, resulting in noNullPointerException
being thrown.Addressed Issue
Closes #2317
Checklist
- [ ] This PR implements an enhancement, and I have provided tests to verify that it works as intended- [ ] This PR introduces changes to the database model, and I have added corresponding update logic- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly