Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BotAI.already_pending #8

Closed
Dentosal opened this issue Jan 18, 2018 · 4 comments
Closed

Improve BotAI.already_pending #8

Dentosal opened this issue Jan 18, 2018 · 4 comments
Labels
enhancement

Comments

@Dentosal
Copy link
Owner

  • Count instances of this building already in progress
  • Count workers currently moving to build the given building
@reypader
Copy link
Contributor

reypader commented Jan 27, 2018 •
edited
Loading

I was able to rework BotAI.already_pending in the build-order-support branch to instead return the count and rely on falsy/truthy values. I'll cherry-pick it and create a PR.

reypader pushed a commit to reypader/python-sc2 that referenced this issue Jan 28, 2018
Partial fix for Dentosal#8 - already_pending returns count instead of…
78cf389 
… boolean
@reypader
Copy link
Contributor

It might be good to also include support for upgrade detection in already_pending.

@reypader
Copy link
Contributor

reypader commented Feb 1, 2018 •
edited
Loading

PR #21 has been fixed to return 0 when none of the conditions are met

@Dentosal
Copy link
Owner Author

Dentosal commented Feb 1, 2018

Merged.

@Dentosal Dentosal closed this as completed Feb 1, 2018
tweakimp added a commit that referenced this issue Apr 24, 2019
@tweakimp
Merge pull request #8 from BurnySc2/develop
12e3654 
Fix pixelmaps, ramp walls, and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dentosal @reypader