only load configured auth strategies #6
Closed
+43
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tilgovi! I'll keep an eye on this! 👍 |
|
What about this? |
|
This pull request is no longer valid |
LegislaturaCABA
referenced
this pull request
in Legislatura/demos
Oct 29, 2014
LegislaturaCABA
referenced
this pull request
in Legislatura/demos
Oct 29, 2014
LegislaturaCABA
referenced
this pull request
in Legislatura/demos
Oct 29, 2014
LegislaturaCABA
referenced
this pull request
in Legislatura/demos
Oct 29, 2014
…aff member. Closes #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Partido De La Red session at TransparencyCamp just now I learned about the platform you are building.
The first thing I ran into when cloning and running locally was that removing Facebook from the config causes exception on start.
It should be possible to use only some auth providers. For testing, it's particularly convenient to have username/password and not need keys for social networks.
This is not quite ready to merge. It still shows the FB login in the top right corner. I'm not familiar enough with express or jade to know how to get information on configured strategies for making a conditional in the layout template.
With a little guidance on this, I'll finish up this PR.