Refactored common elements of GenerateAssertionsRequest.java and GetA… #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssertionsRequest.java into an abstract superclass called ContestRequest.java
michelleblom
approved these changes
Mar 27, 2024
src/main/java/au/org/democracydevelopers/raireservice/request/ContestRequest.java
Show resolved
Hide resolved
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.springframework.data.annotation.ReadOnlyProperty; | ||
|
|
There was a problem hiding this comment.
What do we mean by "request describing a contest"? What is this class of contest requests for?
There was a problem hiding this comment.
I changed it to 'identifying a contest and listing its candidates' - its an abstract class that summarises only those things that are common to all requests. Maybe I haven't made it very clear - feel free to suggest better wording.
| @@ -13,22 +13,13 @@ the raire assertion generation engine (https://github.com/DemocracyDevelopers/ra | |||
|
|
|||
| import au.org.democracydevelopers.raireservice.persistence.repository.ContestRepository; | |||
| import java.util.List; | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
| import org.springframework.data.annotation.ReadOnlyProperty; | |||
|
|
|||
There was a problem hiding this comment.
I'm still not sure what it means for a request to "describe a contest".
There was a problem hiding this comment.
Changed to "identifying the contest..."
src/main/java/au/org/democracydevelopers/raireservice/request/ContestRequest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssertionsRequest.java into an abstract superclass called ContestRequest.java
Completes #51