Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sample dashboard page #98

Merged
merged 6 commits into from
Oct 12, 2024
Merged

Conversation

ylimezhang
Copy link
Collaborator

  • add search bar text
  • add clear for search bar
  • add highlight circle for selected candidate/searched candidate

Vercel link: ( note the link is before the newest PR - without revert function for now) : https://audit-visualizer-mu.vercel.app/

const [selectedCandidateId, setSelectedCandidateId] = useState<number | null>(
null,
);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么不能用外部传入的selectedWinnerId呢?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在这种会有Bug,第一次展示tree的时候,当前展示的树并没有一圈蓝色

@ylimezhang ylimezhang requested a review from Mirrorgo October 12, 2024 06:13
@@ -104,7 +104,7 @@ function EliminationTree() {
/>
</div>

{/* <Dropdown /> */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个按钮已经删掉了!!!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗷嗷嗷 我以为你最后才删现在还有用我就没选这个 sorry 这就注释掉 :(

…dd difficulty/margin for sample file ( not these number is not real)
@ylimezhang ylimezhang requested a review from Mirrorgo October 12, 2024 07:18
@Mirrorgo Mirrorgo merged commit eeb7502 into release Oct 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants