Feature/sample dashboard page #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the upload page style
Prepare for deploying the emily‘s branch to see the sample page
feat: AssertionsDetailsModal added
…mocracyDevelopers/AuditVisualizer into feature/sample-dashboard-page
Auroraphile
requested review from
Mirrorgo,
Linkgls,
ylimezhang and
xYoung0507
Mirrorgo
reviewed
Oct 5, 2024
There was a problem hiding this comment.
一般很少自己用table标签写,应该是用shadcn本身的table组件库写.但是目前先这样吧
Mirrorgo
reviewed
Oct 5, 2024
| const avatarColor = new AvatarColor(); | ||
|
|
||
| const Avatar: React.FC<AvatarProps> = ({ userId, userName, totalUsers }) => { | ||
| const isWithinColorLimit = userId < 16; // |
There was a problem hiding this comment.
为什么是用id判断?这个之后估计得改. 应该是外部的一个全局状态存储了candidate的list,然后那个list size比16大,然后触发超出16个的逻辑.这部分下个sprint写也行
Mirrorgo
reviewed
Oct 5, 2024
| const candidate = candidateList.find((candidate) => candidate.id === userId); | ||
| const backgroundColor = candidate ? candidate.color : "#CCCCCC"; | ||
|
|
||
| const styles: React.CSSProperties = { |
There was a problem hiding this comment.
可以让gpt改tailiwind的写法写,保证统一,这个我之后来改吧
Mirrorgo
reviewed
Oct 5, 2024
| const AssertionTable: React.FC<AssertionTableProps> = ({ assertions }) => { | ||
| return ( | ||
| <div> | ||
| <table className="min-w-full table-auto"> |
There was a problem hiding this comment.
这里也是不用自己写table的问题,但是不改也行了,就先这样吧
Mirrorgo
reviewed
Oct 5, 2024
|
|
||
| <p className="text-sm text-gray-500 text-center mt-4"> | ||
| By sharing your files or using our service, you agree to our{" "} | ||
| <a href="#" className="text-blue-500"> |
There was a problem hiding this comment.
这里用a标签是? 应该用next的link标签,另外, 这里href是怎么回事?没有实际路径
Mirrorgo
reviewed
Oct 5, 2024
| </p> | ||
| <p className="text-center mt-4 text-gray-500"> | ||
| Need help? Click{" "} | ||
| <Link href="#" className="text-blue-500 hover:underline"> |
Mirrorgo
reviewed
Oct 5, 2024
| @@ -96,7 +96,7 @@ const Uploader: React.FC<UploaderProps> = ({ className }) => { | |||
| your files | |||
| </p> | |||
| <p className="text-gray-400 mb-2">or</p> | |||
| <a href="#" className="text-blue-600"> | |||
| <a href="/sample" className="text-blue-600"> | |||
Mirrorgo
reviewed
Oct 5, 2024
| . | ||
| </p> | ||
| <p className="text-center mt-4 text-gray-500"> | ||
| Need help? Click{" "} |
Mirrorgo
reviewed
Oct 5, 2024
| const Upload: React.FC = () => { | ||
| useEffect(() => { | ||
| const fetchData = async () => { | ||
| try { |
Mirrorgo
reviewed
Oct 5, 2024
|
|
||
| <p className="text-sm text-gray-500 text-center mt-4"> | ||
| By sharing your files or using our service, you agree to our{" "} | ||
| <a href="#" className="text-blue-500"> |
Mirrorgo
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.