Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not drop out-of-bounds point silently in sel_points #271

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

Huite
Copy link
Collaborator

@Huite Huite commented Aug 8, 2024

Provide some options instead.

Fixes #100

Both this and the changing weights of the regridder reductions are breaking changes, the next version should be a bigger increment in version number.

@Huite Huite requested a review from veenstrajelmer August 8, 2024 12:04
Copy link
Collaborator

@veenstrajelmer veenstrajelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Een paar vragen, maar ziet er goed uit. Ik heb het ook getest met mijn beperkte testcase en het werkt heerlijk, super bedankt!

xugrid/ugrid/ugrid1d.py Outdated Show resolved Hide resolved
xugrid/ugrid/ugrid2d.py Outdated Show resolved Hide resolved
xugrid/ugrid/ugridbase.py Outdated Show resolved Hide resolved
@Huite Huite merged commit e5487e4 into main Aug 8, 2024
14 checks passed
@Huite Huite deleted the sel-points-bounds branch August 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sel_points silently drops outofbounds points
2 participants