Refactor reduce module; improve performance for mode, median #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify methods by just giving a contiguous values array instead of source and indices * Provide a pre-allocated workspace to avoid dynamic allocation in reduce functions * Add a generalized percentile function
Small miscellaneous fixes.
JoerivanEngelen
approved these changes
Aug 6, 2024
| return values, weights, work | ||
|
|
||
|
|
||
| def reverse_args(): |
There was a problem hiding this comment.
To remove some duplicate code and show the precise difference between forward and reverse args, you can simplify this function to:
Suggested change
| def reverse_args(): | |
| def reverse_args(): | |
| values, weights, work = forward_args() | |
| return np.flip(values), weights, work |
(FYI: I wasn't allowed by Github to put a multi-line suggestion here, as some lines are deleted. Therefore put the suggestion just on the function definition line).
xugrid/regrid/nanpercentile.py
Outdated
| @@ -0,0 +1,97 @@ | |||
| """ | |||
| Numba percentile methods allocate continuosly on the heap. | |||
There was a problem hiding this comment.
Suggested change
| Numba percentile methods allocate continuosly on the heap. | |
| Numba percentile methods allocate continuously on the heap. |
xugrid/regrid/regridder.py
Outdated
Comment on lines
468
to
473
| Examples | ||
| -------- | ||
| Setup a custom percentile method and apply it: | ||
|
|
||
| >>> p33_3 = OverlapRegridder.create_percentile_method(33.3) | ||
| >>> regridder = OverlapRegridder(source, target, method=p33_3) |
There was a problem hiding this comment.
Good that you are adding an example of the percentiles. I think most users are just looking for the simple use case, so for them it is better to start with the simplest example. And perhaps also guide them to what is the most important method to call (regrid)?
Suggested change
| Examples | |
| -------- | |
| Setup a custom percentile method and apply it: | |
| >>> p33_3 = OverlapRegridder.create_percentile_method(33.3) | |
| >>> regridder = OverlapRegridder(source, target, method=p33_3) | |
| Examples | |
| -------- | |
| Create an OverlapRegridder to regrid with means: | |
| >>> regridder = OverlapRegridder(source_grid, target_grid, method="mean") | |
| >>> regridder.regrid(source_data) | |
| Setup a custom percentile method and apply it: | |
| >>> p33_3 = OverlapRegridder.create_percentile_method(33.3) | |
| >>> regridder = OverlapRegridder(source_grid, target_grid, method=p33_3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240