Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added edge_node_connectivity to Ugrid2d.from_meshkernel #250

Merged
merged 3 commits into from
Jul 3, 2024
Merged

added edge_node_connectivity to Ugrid2d.from_meshkernel #250

merged 3 commits into from
Jul 3, 2024

Conversation

veenstrajelmer
Copy link
Collaborator

No description provided.

@veenstrajelmer veenstrajelmer linked an issue Jul 1, 2024 that may be closed by this pull request
from_meshkernel method: use all attributes #148
Closed
@veenstrajelmer veenstrajelmer mentioned this pull request Jul 1, 2024
Closed
JoerivanEngelen
JoerivanEngelen approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! Could you also update the changelog?

@veenstrajelmer veenstrajelmer merged commit 9283eb6 into main Jul 3, 2024
11 checks passed
@veenstrajelmer veenstrajelmer deleted the 148-from_meshkernel-method-use-all-attributes branch July 3, 2024 08:24
@Huite Huite mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoerivanEngelen JoerivanEngelen JoerivanEngelen approved these changes

@Huite Huite Awaiting requested review from Huite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

from_meshkernel method: use all attributes
2 participants
@veenstrajelmer @JoerivanEngelen