Issue #964 from imod5 classmethbod DIS #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… helper funtion to _is_valid
JoerivanEngelen
changed the base branch from
master
to
imod5_converter_feature_branch
luitjansl
reviewed
Apr 29, 2024
luitjansl
reviewed
Apr 29, 2024
luitjansl
reviewed
Apr 29, 2024
imod/mf6/dis.py
Outdated
|
|
||
| target_grid = get_smallest_target_grid(*data.values()) | ||
|
|
||
| regridder_settings = cls._regrid_method |
There was a problem hiding this comment.
make a deepcopy of cls._regrid_method to avoid changing the defaults in this assignment. This is something that must be done at more locations. probably every implementation of "get_regrid_methods"should do this.
There was a problem hiding this comment.
Very good catch! Implementing this elsewhere is worthy of its own issue. Created an issue for this #1000
luitjansl
reviewed
Apr 29, 2024
luitjansl
reviewed
Apr 29, 2024
luitjansl
reviewed
Apr 29, 2024
luitjansl
reviewed
Apr 29, 2024
luitjansl
reviewed
Apr 29, 2024
luitjansl
approved these changes
Apr 30, 2024
JoerivanEngelen
merged commit 72515e6
into
imod5_converter_feature_branch
6 of 7 checks passed
luitjansl
added a commit
that referenced
this pull request
May 8, 2024
luitjansl
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964
Description
Implements from_imod5 classmethod to StructuredDiscretization classmethod.
NOTE: I had to modify the default regridding method of "idomain" as the "mode" method appears to have a bug with perfectly aligned structured grids.
This bug requires further investigation. Will post an issue if found.
Checklist
Issue #nr, e.g.Issue #737