Add from_imod5_data method and test #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manangka
approved these changes
Dec 4, 2024
JoerivanEngelen
merged commit 8e55dd5
into
issue_#1260_from_imod5_data_metaswap
6 of 7 checks passed
JoerivanEngelen
deleted the
issue_#1324_ScalingFactors_from_imod5_data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1324
Description
Adds a
ScalingFactors.from_imod5_datamethod. I think, the final missing constructor method.Scaling factors for urban areas are set 1.0, not sure if iMOD5 does this as well @HendrikKok?
Checklist
Issue #nr, e.g.Issue #737