Issue #1290 infiltration from imod5 #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m_imod5_data method
…infiltration_from_imod5
|
Manangka
approved these changes
Nov 15, 2024
| def from_imod5_data(cls, imod5_data: dict[str, GridDataDict]) -> "Infiltration": | ||
| cap_data = imod5_data["cap"] | ||
| data = {} | ||
| # Use runon resistance as downward resistance, and runoff for downward |
There was a problem hiding this comment.
I think run-on needs to have a dash in it. At least that's what i find online. The weird thing is that it is not needed for runoff
There was a problem hiding this comment.
Weird! I think I prefer keeping the naming consistent (i.e. "runon" and "runoff"), as I like consistency and python variable names cannot contain a dash
JoerivanEngelen
merged commit c2f9f52
into
issue_#1260_from_imod5_data_metaswap
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1290
Description
Adds from_imod5_data classmethod.
Requirements:
I also added the
upward_resistanceanddownward_resistanceto the list with grids which have a subunit coordinate, as a comment in @HendrikKok's script mentioned this was missing, and a required feature.Checklist
Issue #nr, e.g.Issue #737