Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1187 cleanup wells #1206

Merged

Conversation

JoerivanEngelen
Copy link
Contributor

Fixes #1187

Description

Adds cleanup utility for wells, as well as a method on the Well object. LayeredWell doesn't have cleanup method yet, as cleaning up almost purely focuses on adjusting filter screen levels for now. The function as well as the method are a bit more involved than the other cleanup utilities, because we are dealing here with a comparison of point data and grids.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

@JoerivanEngelen
Copy link
Contributor Author

FYI: I fixed the issues Sonarcloud raised, but it keeps reviewing an old changeset...

imod/mf6/wel.py Show resolved Hide resolved
imod/mf6/wel.py Outdated Show resolved Hide resolved
imod/prepare/cleanup.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 11, 2024

@JoerivanEngelen JoerivanEngelen merged commit 657a0a8 into imod5_converter_feature_branch Sep 11, 2024
6 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1187_cleanup_wells branch September 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants