Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1051 validate well filters #1062

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Issue #1051 validate well filters #1062

merged 4 commits into from
Jun 7, 2024

Conversation

luitjansl
Copy link
Contributor

Fixes #1051

Description

Now validates that well top > well bottom.

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

JoerivanEngelen
JoerivanEngelen approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you also update the changelog? Otherwise we might forget inform users. Approving in advance.

You could also merge this to master if you want, as it is not really related to this feature branch.

@luitjansl luitjansl merged commit 0eed7f8 into imod5_converter_feature_branch Jun 7, 2024
7 checks passed
@luitjansl luitjansl deleted the issue_#1051_validate_well_filters branch June 7, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoerivanEngelen JoerivanEngelen JoerivanEngelen approved these changes

@HendrikKok HendrikKok Awaiting requested review from HendrikKok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luitjansl @JoerivanEngelen