Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create converter of iMOD5 horizontal flow barrier data to grid agnostic HorizontalFlowBarrier package #502

Closed
Manangka opened this issue Dec 11, 2023 · 1 comment
Closed

Create converter of iMOD5 horizontal flow barrier data to grid agnostic HorizontalFlowBarrier package #502

Manangka opened this issue Dec 11, 2023 · 1 comment
Assignees
@luitjansl
Milestone
v1.0: Backwards C...

Comments

@Manangka
Copy link
Collaborator

Manangka commented Dec 11, 2023 •
edited
Loading

In GitLab by @JoerivanEngelen on Aug 1, 2023, 17:58
@Manangka Manangka mentioned this issue Dec 12, 2023
Closed
4 tasks
@Manangka Manangka changed the title [PLACEHOLDER] - for issue #502 Create converter of iMOD5 horizontal flow barrier data to grid agnostic HorizontalFlowBarrier package Dec 12, 2023
@Manangka Manangka reopened this Dec 12, 2023
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jan 16, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Mar 27, 2024
@luitjansl luitjansl moved this from 🤝 Accepted to 🏗 In Progress in iMOD Suite Jun 6, 2024
@luitjansl luitjansl self-assigned this Jun 6, 2024
@luitjansl luitjansl mentioned this issue Jun 7, 2024
Merged
5 tasks
@luitjansl luitjansl moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Jun 7, 2024
JoerivanEngelen added a commit that referenced this issue Jun 14, 2024
@luitjansl @JoerivanEngelen
Issue #502 hfb import (#1070)
f2e70aa 
Fixes #502 

# Description
Converts hfb's from imod5 to mf6, but only in the following cases:

- the hfb has an assgined layer that is not zero
- the hfb is mappable to the LayeredHorizontalFlowBarrierResistance
class.

It creates a single mf6 hfb package containing all the hfb's that are
present in the model domain area.
The hfb package is added to the simulation. 

# Checklist

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example

---------

Co-authored-by: Joeri van Engelen <[email protected]>
@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Jun 14, 2024 •
edited
Loading

Fixed in #1070

@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Jun 14, 2024
JoerivanEngelen added a commit that referenced this issue Jun 18, 2024
@JoerivanEngelen @luitjansl
Issue #502 hfb import (#1078)
2e7bc85 
Follow-up on: #1070

# Description
For some reason, I erronously merged #1070. This implements my
suggestion to concatenate pandas dataframes.

# Checklist
<!---
Before requesting review, please go through this checklist:
-->

- [x] Links to correct issue
- [ ] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [ ] Unit tests were added
- [ ] **If feature added**: Added/extended example

---------

Co-authored-by: luitjan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luitjansl luitjansl

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
v1.0: Backwards Compatibility iMOD5
Development

No branches or pull requests
3 participants
@JoerivanEngelen @luitjansl @Manangka