Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imod.msw.Sprinkling.from_imod5_data #1311

Closed
Tracked by #1260
JoerivanEngelen opened this issue Nov 26, 2024 · 0 comments · Fixed by #1312
Closed
Tracked by #1260

Add imod.msw.Sprinkling.from_imod5_data #1311

JoerivanEngelen opened this issue Nov 26, 2024 · 0 comments · Fixed by #1312
Assignees
@JoerivanEngelen
Milestone
v1.0: Backwards C...

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Nov 26, 2024 •
edited
Loading

Based on @HendrikKok's conversion prototype:

What I didn't really get in the script yet was why the "artificial_recharge_capacity" grid is not taken there, but instead it is set to 0.001 * 'rural_infiltration_capacity'.

Requirements

  • Derive max_abstraction_groundwater grid, where artificial_recharge == 1
  • Derive max_abstraction_surfacewater grid, where artificial_recharge == 2
  • If groundwater extraction, then set surface water extraction to 0
  • Convert recharge artificial layer grid to LayeredWell package
  • Wells in inactive layers should deactivated.
  • Throw NotImplementedError if dataframe provided instead of grid
@JoerivanEngelen JoerivanEngelen mentioned this issue Nov 26, 2024
Open
9 tasks
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Nov 26, 2024
@JoerivanEngelen JoerivanEngelen changed the title Sprinkling: Add imod.msw.Sprinkling.from_imod5_data Nov 26, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Nov 26, 2024
@JoerivanEngelen JoerivanEngelen moved this from 🤝 Accepted to 📝Refined in iMOD Suite Nov 26, 2024
@JoerivanEngelen JoerivanEngelen self-assigned this Nov 26, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📝Refined to 🏗 In Progress in iMOD Suite Nov 26, 2024
@JoerivanEngelen JoerivanEngelen mentioned this issue Nov 28, 2024
Merged
5 tasks
@JoerivanEngelen JoerivanEngelen moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Nov 29, 2024
JoerivanEngelen added a commit that referenced this issue Dec 3, 2024
@JoerivanEngelen
Issue #1311 sprinkling from imod5 data (#1312)
68b5ef2 
Fixes #1311

# Description

Adds the following:

- ``imod.mf6.LayeredWell.from_imod5_cap_data``, to construct
LayeredWells for MODLOW6 from the CAP package in iMOD5 Data. Throws an
error if data is provided as point data (IPF, which is read as pandas
DataFrame). This has rate 0.0, actual rates will be inserted by in the
coupling scheme of iMOD Coupler.
- ``imod.mf6.GroundwaterFlowModel.from_imod5_data`` adds Sprinkling well
if CAP package present. This does not affect MODFLOW6 model if not
coupled to MetaSWAP: The wells have rates 0.0, so will not affect the
simulation results.
- ``Sprinkling.from_imod5_data`` to construct a Sprinkling package from
iMOD5 data.

# Checklist
<!---
Before requesting review, please go through this checklist:
-->

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
v1.0: Backwards Compatibility iMOD5
Development

Successfully merging a pull request may close this issue.

Issue #1311 sprinkling from imod5 data Deltares/imod-python
1 participant
@JoerivanEngelen