Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Well: Issues when importing steady-state from iMOD5 #1166

Closed
Tracked by #1155
JoerivanEngelen opened this issue Aug 21, 2024 · 1 comment
Closed
Tracked by #1155

Well: Issues when importing steady-state from iMOD5 #1166

JoerivanEngelen opened this issue Aug 21, 2024 · 1 comment
Assignees
@JoerivanEngelen
Milestone
v1.0: Backwards C...

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Aug 21, 2024 •
edited
Loading

The GridAgnostic.from_imod5_data is currently is not able to import steady-state wells from a projectfile. I've found the following things which have to be changed:

  • For associated wells resample_timeseries creates problems in the final pd.merge, where an empty dataframe is generated
  • Unassociated wells shouldn't get a multi-index with a "time" index in case of steady-state.
  • _df_groups_to_da_rates shouldn't use a "time" dimension
@JoerivanEngelen JoerivanEngelen self-assigned this Aug 21, 2024
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Aug 21, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🏗 In Progress in iMOD Suite Aug 21, 2024
@JoerivanEngelen JoerivanEngelen changed the title Issues when writing LHM steady-state Wel: Issues when writing steady-state Aug 21, 2024
@JoerivanEngelen JoerivanEngelen changed the title Wel: Issues when writing steady-state Well: Issues when importing steady-state from iMOD5 Aug 21, 2024
This was referenced Aug 21, 2024
Open
Merged
@JoerivanEngelen JoerivanEngelen moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Aug 21, 2024
JoerivanEngelen added a commit that referenced this issue Aug 23, 2024
@JoerivanEngelen
Issue #1166 steady state well import (#1169)
546ad47 
Fixes #1166 and somewhat fixes #1163

# Description
- Moves ``pd.to_datetime`` logic to separate place, use
``errors="coerce"`` setting, which turns datetimes beyond the year 2261
to ``pd.NaT``. These seem to be consequently ignored in the
``resample_timeseries``.
- Truncate well names to max 16 characters
- Support wells defined in "steady-state" entry in the projectfile.
- Add test cases for this.

# Checklist
- [x] Links to correct issue
- [ ] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@JoerivanEngelen
Copy link
Contributor Author

Fixed in #1169

@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
v1.0: Backwards Compatibility iMOD5
Development

No branches or pull requests
1 participant
@JoerivanEngelen