Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from_imod5_data method to LayeredWell class #1122

Closed
Tracked by #501
JoerivanEngelen opened this issue Jul 26, 2024 · 0 comments
Closed
Tracked by #501

Add from_imod5_data method to LayeredWell class #1122

JoerivanEngelen opened this issue Jul 26, 2024 · 0 comments
Assignees
@JoerivanEngelen
Milestone
v1.0: Backwards C...

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Jul 26, 2024 •
edited
Loading

#1121 Adds LayeredWell class, but this still lacks a from_imod5_data method. This should still be added.
@JoerivanEngelen JoerivanEngelen mentioned this issue Jul 26, 2024
Closed
8 tasks
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Jul 26, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 🤝 Accepted in iMOD Suite Jul 26, 2024
@JoerivanEngelen JoerivanEngelen self-assigned this Jul 26, 2024
@JoerivanEngelen JoerivanEngelen moved this from 🤝 Accepted to 🏗 In Progress in iMOD Suite Jul 26, 2024
@JoerivanEngelen JoerivanEngelen mentioned this issue Jul 26, 2024
Merged
5 tasks
@JoerivanEngelen JoerivanEngelen moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Jul 29, 2024
JoerivanEngelen added a commit that referenced this issue Jul 29, 2024
@JoerivanEngelen
Issue #1122 layered well from imod5 data (#1123)
820e92f 
Fixes #1122, should be merged after
#1121 (so duplication in
changeset)

# Description
Adds ``from_imod5_data`` method to ``LayeredWell`` object.

# Checklist
- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [x] **If feature added**: Added/extended example
@JoerivanEngelen JoerivanEngelen moved this from 🧐 In Review to ✅ Done in iMOD Suite Jul 29, 2024
JoerivanEngelen added a commit that referenced this issue Jul 29, 2024
@JoerivanEngelen
Issue #1122 review comments (#1128)
b95291d 
Forgot to push fixes for review comments, this impelements this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
v1.0: Backwards Compatibility iMOD5
Development

No branches or pull requests
1 participant
@JoerivanEngelen