Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move inflow points to confluence if within buffer from model boundary #202

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

DirkEilander
Copy link
Contributor

Issue addressed

Fixes issue with multiple inflow points near confluence.
In case of a confluence near the model region I want to be able to select the confluence (see figure b) rather than both tributaries as inflow points (see figure a). This is achieved by removing small river segments that completely fall within a user-defined buffer from the model boundary. The most upstream point of the remaining river is than located at the confluence.

figure a: inflow at to closeby tributaries before fix
image

figure b: inflow at confluence after fix
image

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@DirkEilander DirkEilander requested a review from roeldegoede June 18, 2024 08:04
@roeldegoede roeldegoede merged commit e5245a9 into main Aug 29, 2024
6 checks passed
@DirkEilander DirkEilander deleted the river-inflow-fix branch August 29, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants