Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nodata value to raster before writing #199

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Added nodata value to raster before writing #199

merged 4 commits into from
Jun 3, 2024

Conversation

gutierrad
Copy link
Contributor

Issue addressed

Fixes #198

Explanation

Set nodata value before masking (and after possible maximum value calculations)

Checklist

  • [NA] Updated tests or added new tests - Haven't found other appearances of the method
  • Branch is up to date with main
  • [NA] Updated documentation if needed - Maybe uncomment the example?
  • [NA] Updated changelog.rst if needed

roeldegoede
roeldegoede approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@roeldegoede roeldegoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for bringing up the solution as well

@roeldegoede roeldegoede merged commit c84c590 into Deltares:main Jun 3, 2024
6 checks passed
@gutierrad gutierrad deleted the write_raster_nodata_bug branch June 3, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeldegoede roeldegoede roeldegoede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write_raster fails when trying to write results
2 participants
@gutierrad @roeldegoede