Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify ind method #189

Merged
merged 4 commits into from
Mar 14, 2024
Merged

simplify ind method #189

merged 4 commits into from
Mar 14, 2024

Conversation

DirkEilander
Copy link
Contributor

Issue addressed

Simplify calculating a mask from indices

Explanation

Explain how you addressed the bug/feature request, what choices you made and why.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

Copy link
Collaborator

@roeldegoede roeldegoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work on the test as well!

Two things I noticed;

  • this branch is not up-to-date with main (better to always pull from main first right?)
  • we never changed the version to 1.0.4.dev (maybe good to still to this within this very simple PR)

@DirkEilander
Copy link
Contributor Author

Thanks for the review. I just updated the branch and bumped the version number.

@roeldegoede roeldegoede merged commit 16bc157 into main Mar 14, 2024
6 checks passed
@roeldegoede roeldegoede deleted the simplify_ind branch September 18, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants