Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI & use pre-commit for linting #163

Merged
merged 13 commits into from
Dec 22, 2023
Merged

Update CI & use pre-commit for linting #163

merged 13 commits into from
Dec 22, 2023

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Dec 20, 2023

Issue addressed

Same automation updates based on recent work in the core.

major update CI

  • use pip install and caching for faster tests
  • test weekly against latest hydromt core main branch
  • separate linting from test based on pre-commit hooks
  • add dependabot

dev environment

introduction pixi for simple environment handling and shortcuts for building docs, testing etc. Setting up a dev environment including pre-commit hooks can be done with one line pixi run dev across different OS. Installation of pixi is super straight forward. With a small script (make_env.py) we can now also administrate all dependencies in one place, the pyproject.tom. Note that dev environment still exist and use of pixi is optional

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Updated documentation if needed
  • Updated changelog.rst if needed

Additional Notes (optional)

Add any additional notes or information that may be helpful.

Copy link
Collaborator

@roeldegoede roeldegoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mooi werk!

@DirkEilander DirkEilander merged commit 0d239ee into main Dec 22, 2023
5 checks passed
@DirkEilander DirkEilander deleted the update_ci_linting branch December 22, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants