fix filter timeseries in setup_x_forcing #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes filtering of timeseries in case you have a large dataset in separate files for the timeseries and locations (rather than one geodataset). If the locations are filtered based on the model region a subset of the locations and all timeseries are passed to the
set_1d_forcing
method raising an error that the indices do not match.Explanation
Add a filtering step after reading the location in
setup_waterlevel_forcing
andsetup_discharge_forcing
Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.