Fix downscaling large models #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirkEilander
approved these changes
Nov 8, 2023
hydromt_sfincs/utils.py
Outdated
| with rasterio.open(dep) as src: | ||
| # Define block size | ||
| n1, m1 = src.shape | ||
| nrcb = 2000 # nr of cells in a block |
There was a problem hiding this comment.
Good one, added an nrmax (similar as in setup_subgrid) argument.
| # check for nan-data | ||
| if np.all(np.isnan(block_data)): | ||
| continue | ||
| # Convert row and column indices to pixel coordinates |
There was a problem hiding this comment.
I don't think we need to do this now, but since we are working with rasterio (rather than xarray) it would make sense to also directly use the rasterio warp method rather than the raster.reproject method in _downscale_floodmap_da. I think this could provide quite a significant performance improvement. That would affect the whole block of code below this line.
There was a problem hiding this comment.
Interesting suggestion but let's postpone that for now. I added a TODO to the code
Co-authored-by: DirkEilander <[email protected]>
…s/hydromt_sfincs into fix_downscaling_large_models
…tares/hydromt_sfincs into fix_downscaling_large_models
…o fix_downscaling_large_models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR builds upon #144 and it solves issue #127