Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39 setup urban sewer network from global data project overview #60

Draft
wants to merge 59 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
255e348
add urban sewer network function heads
xldeltares Aug 15, 2023
40c7f30
add test placeholder
xldeltares Aug 15, 2023
c6da568
small fix
xldeltares Aug 15, 2023
1b2bf86
setup graph from osm network (draft)
xldeltares Aug 15, 2023
3b5836d
draft setup_graph_from_hydrography
xldeltares Aug 17, 2023
2e78283
update gitignore
xldeltares Aug 18, 2023
9f3d0c9
fixes
xldeltares Aug 18, 2023
f085499
allow user to use road_types only
xldeltares Aug 18, 2023
1bca52f
refactor graph workflows into utils
xldeltares Aug 18, 2023
92fb551
fix pre-commit hook where relevant
xldeltares Aug 18, 2023
116c2d5
Merge pull request #68 from Deltares/urbansewer/40-setup_network_from…
xldeltares Aug 18, 2023
54478d4
add utils for graph properties
xldeltares Aug 22, 2023
6476a1c
update graph based on dem
xldeltares Aug 22, 2023
e253bfa
small cleanup
xldeltares Aug 22, 2023
997700d
Merge branch 'main' into 69-create-street-slopes-based-on-a-hydrologi…
xldeltares Aug 31, 2023
93e3c36
update to main format
xldeltares Aug 31, 2023
5db789b
remove ra2ce dependency
xldeltares Sep 5, 2023
edd1af9
setup entire system from osm + refactor
xldeltares Sep 5, 2023
08052c7
setup urban sewer network topology from osm (include both open and cl…
xldeltares Sep 7, 2023
22978e9
code cleanup
xldeltares Sep 7, 2023
4bbd838
fix bug in reverse branch
xldeltares Sep 7, 2023
9c5ebe2
Merge pull request #75 from Deltares/69-create-street-slopes-based-on…
xldeltares Sep 18, 2023
fd72781
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
xldeltares Nov 30, 2023
4896a59
add missing function from merge action
xldeltares Nov 30, 2023
13df99c
add funcs from hybridurb (draft)
xldeltares Nov 30, 2023
9269561
adapt graph utils
xldeltares Dec 1, 2023
6cf7849
graph optimisation draft
xldeltares Dec 1, 2023
353002b
refactor
xldeltares Dec 4, 2023
9c33844
small fix for flwdir
xldeltares Dec 5, 2023
6c4c998
add pipe optimization
xldeltares Dec 13, 2023
76a9e0a
improvements and fixes for pipe topology optimization
xldeltares Dec 14, 2023
cc7c21d
draft of calculate hydraulic parameters
xldeltares Dec 14, 2023
1356c87
Initial commit for urbansewernetwork.py
MRadema Dec 21, 2023
bd3df8b
improve calculate hydraulic dimentions
xldeltares Dec 21, 2023
205b230
Merge remote-tracking branch 'origin/44-setup_network_dimentions_from…
xldeltares Dec 21, 2023
b6d5e65
add missing pieces (landuse and rainfall assumption)
xldeltares Dec 21, 2023
8bdf2df
add rainfall static and fix calculate hydraulic dimentions and others
xldeltares Dec 22, 2023
c4a2382
small fixes that was needed to build model from urban drainage system…
xldeltares Jan 9, 2024
f6c6ac0
crosssection funcs
xldeltares Jan 9, 2024
4f19560
add modelbuilding workflow for urban sewer network
xldeltares Jan 9, 2024
bde9a5e
resolved conflicts
veenstrajelmer Oct 16, 2024
5a44ab8
rename envname back
veenstrajelmer Oct 16, 2024
7aec12a
rename envname back
veenstrajelmer Oct 16, 2024
0125e26
fixed linting
veenstrajelmer Oct 16, 2024
515d409
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 16, 2024
8ce6f31
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 16, 2024
cafb032
minimized diff
veenstrajelmer Oct 16, 2024
e39831e
updated test_model_build
veenstrajelmer Oct 16, 2024
91e8189
prevented urbansewernetwork in test_model_class test
veenstrajelmer Oct 16, 2024
66786c1
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 18, 2024
441a811
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 18, 2024
0852fde
minimized diff
veenstrajelmer Oct 18, 2024
accf3ac
minimized diff
veenstrajelmer Oct 18, 2024
e859029
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 18, 2024
3655183
re-added additional dependencies
veenstrajelmer Oct 18, 2024
0fb25f4
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 18, 2024
1ce597b
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 18, 2024
43969f5
renamed file
veenstrajelmer Oct 24, 2024
892ed5b
Merge branch 'main' into 39-setup-urban-sewer-network-from-global-dat…
veenstrajelmer Oct 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolved conflicts
veenstrajelmer committed Oct 16, 2024
commit bde9a5e3460e35971139bd5a8d302b05ae63ef93
1 change: 0 additions & 1 deletion hydromt_delft3dfm/workflows/boundaries.py
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@

from hydromt_delft3dfm import graph_utils


logger = logging.getLogger(__name__)

__all__ = [
9 changes: 5 additions & 4 deletions hydromt_delft3dfm/workflows/crosssections.py
Original file line number Diff line number Diff line change
@@ -602,10 +602,11 @@ def set_point_crosssections(
return pd.DataFrame()

# get branch friction (regard crosssections')
_friction_cols = ["frictionid", "frictiontype", "frictionvalue"]
crosssections = crosssections.drop(
columns=["frictionid", "frictiontype", "frictionvalue"]
columns=[c for c in _friction_cols if c in crosssections.columns],
).merge(
branches[["frictionid", "frictiontype", "frictionvalue"]],
branches[_friction_cols],
left_on="branch_id",
right_index=True,
)
@@ -1026,11 +1027,11 @@ def _set_xyz_crs(crosssections: gpd.GeoDataFrame):
"crsdef_xcoordinates": c.xcoordinates,
"crsdef_ycoordinates": c.ycoordinates,
"crsdef_zcoordinates": c.zcoordinates,
"crsdef_frictionpositions": f"0 { c.ycoordinates.split(' ')[-1]}",
"crsdef_closed": c.closed,
"crsdef_frictionids": c.frictionid,
"frictiontype": c.frictiontype,
"frictionvalue": c.frictionvalue,
"crsdef_frictionpositions": c.frictionpositions,
}
)
crslocs.append(
@@ -1057,7 +1058,7 @@ def _set_xyz_crs(crosssections: gpd.GeoDataFrame):
return crosssections_


def xyzp2xyzl(xyz: pd.DataFrame, sort_by: list = ["x", "y"]):
def xyzp2xyzl(xyz: pd.DataFrame, sort_by: list = ["x", "y"]) -> gpd.GeoDataFrame:
"""Convert xyz points to xyz lines.

Parameters
You are viewing a condensed version of this merge commit. You can view the full changes here.