Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix catalog reference to correct hash #1070

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Jaapel
Copy link
Contributor

@Jaapel Jaapel commented Sep 27, 2024

Issue addressed

Reference to main in old catalog format

@Jaapel Jaapel added the Bug Something isn't working label Sep 27, 2024
@Jaapel Jaapel requested a review from savente93 September 27, 2024 13:46
@Jaapel Jaapel self-assigned this Sep 27, 2024
Copy link
Contributor

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jaapel Jaapel merged commit 91e0cf4 into main Sep 27, 2024
3 of 10 checks passed
@Jaapel Jaapel deleted the fix_mistake_in_predefined_catalog_yml branch September 27, 2024 13:48
@veenstrajelmer veenstrajelmer mentioned this pull request Oct 21, 2024
2 tasks
@veenstrajelmer
Copy link
Collaborator

Unfortunately, this change causes two tests to fail in the main branch. I have created a follow-up issue here: #1093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants