Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize build size #980

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Optimize build size #980

merged 5 commits into from
Sep 25, 2024

Conversation

wkramer
Copy link
Collaborator

@wkramer wkramer commented Sep 19, 2024

Description

Optimize build size.

  1. Large shared libraries will be bundled as separate chunks.
  2. Treeshake Vuetify components, only keep bundle components that are used.

Additionally, we can overrule Vuetify style variables in src/style/settings.scss

Screenshots (if applicable)

If there are any visual changes, please attach screenshots here.

Link to documentation (if applicable)

Add link to public Github pages (only documentation about configuration)

Checklist

  • Make the title short and concise
  • Select the correct label to include it in the release notes:
    • rel: new feature
    • rel: improvement
    • rel: fixes
    • rel: ignore
      Select to rel: ignore if this pull request fixes a New Feature or Improvement in the coming release. Update related Pull Request.
  • Update documentation.
  • Update tests.

@wkramer wkramer linked an issue Sep 19, 2024 that may be closed by this pull request
@wkramer wkramer force-pushed the 979-optimize-build-size branch from 5cd926f to 2b6b156 Compare September 20, 2024 11:41
@wkramer wkramer force-pushed the 979-optimize-build-size branch 2 times, most recently from 4701547 to ac70eaa Compare September 20, 2024 12:07
@wkramer wkramer force-pushed the 979-optimize-build-size branch from 07a9483 to 4187469 Compare September 23, 2024 10:33
Copy link
Collaborator

@ceesvoesenek ceesvoesenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Have you verified that the CSS changes don't break the layout anywhere?

@@ -0,0 +1,3 @@
@use 'vuetify/settings' with (
$data-table-footer-padding: 0px 4px
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style modification was not there before this PR?

@wkramer wkramer mentioned this pull request Sep 24, 2024
@wkramer wkramer force-pushed the 979-optimize-build-size branch from 4187469 to a875201 Compare September 25, 2024 08:41
@wkramer wkramer merged commit b5c8ec6 into main Sep 25, 2024
8 checks passed
@wkramer wkramer deleted the 979-optimize-build-size branch September 25, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize build size
2 participants