Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get fileName for processdata download from workflow properties #903

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Get fileName for processdata download from workflow properties #903

merged 4 commits into from
Jun 18, 2024

Conversation

hvangeffen
Copy link
Collaborator

No description provided.

@hvangeffen hvangeffen linked an issue Jun 10, 2024 that may be closed by this pull request
Get file name from topology #902
Closed
@hvangeffen hvangeffen marked this pull request as draft June 10, 2024 12:36
@hvangeffen hvangeffen self-assigned this Jun 10, 2024
@hvangeffen hvangeffen marked this pull request as ready for review June 11, 2024 10:02
@hvangeffen hvangeffen requested a review from ceesvoesenek June 11, 2024 10:02
ceesvoesenek
ceesvoesenek reviewed Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@ceesvoesenek ceesvoesenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have so much context on what this is supposed to do, but I trust that that is fine.

Some small comments only

src/lib/download/downloadFiles.ts Outdated Show resolved Hide resolved
src/stores/workflows.ts Outdated Show resolved Hide resolved
@hvangeffen hvangeffen force-pushed the 902-get-file-name-from-topology branch from ea2780f to d34c034 Compare June 11, 2024 13:34
@hvangeffen hvangeffen force-pushed the 902-get-file-name-from-topology branch from d34c034 to 2bc90fb Compare June 18, 2024 08:42
@ceesvoesenek ceesvoesenek merged commit fe7d824 into main Jun 18, 2024
5 of 6 checks passed
@ceesvoesenek ceesvoesenek deleted the 902-get-file-name-from-topology branch June 18, 2024 08:43
@bogaardt bogaardt changed the title Get fileName from topology Get fileName for processdata download from workflow properties Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceesvoesenek ceesvoesenek ceesvoesenek approved these changes

Assignees

@hvangeffen hvangeffen

Labels
rel: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get file name from topology
3 participants
@hvangeffen @ceesvoesenek @bogaardt