-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run secondary workflow: improved the string conversion to ensure rounding while drawing bounding box #884
Conversation
36ebb4e
to
a6551ca
Compare
a6551ca
to
9bf8c5d
Compare
const { boundingBox, boundingBoxString } = useBoundingBox(1, 1) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted the changes. I don't understand how the old import accessed global state, but I would like to know. I think I understand how the const { boundingBox, boundingBoxString } = useBoundingBox(1, 1)
creates a new box (the _boundingBox
instantiated in the useBoundingBox
function. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not global state through import sorry,
Definemodel (a compiler macro for prop / emit definition) was accepting the bbox through a prop:
https://vuejs.org/guide/components/v-model.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, the boundingBox is being provided by the parent component as a v-model
, using the workflowsStore.boundingBox
. This does not provide reactivity to the lon/lat values in BoundingBoxControl
when selecting a box.
This doesn't guarantee that the individual members of the BoundingBox will display correctly when accessed.