Period from actions response should be used as fallback for download. #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grijzea
requested changes
May 6, 2024
| function determineViewPeriod(): string { | ||
| const _options = toValue(viewPeriodFromStore) | ||
| let viewPeriod: string = '' | ||
| const startDate: Date | null | undefined = props.startTime |
There was a problem hiding this comment.
I assume that either null or undefined would be sufficient
There was a problem hiding this comment.
startTime from props and options may be of Date, null or undefined. Would have to change there implementation as well, which has a impact on usages of UseTimeSeriesOptions. So even though it is probably better, i don't take it is part of this issue. I will leave it as is for now.
| } | ||
| return `${dateTime.date}T${dateTime.time}Z` | ||
| } | ||
|
|
There was a problem hiding this comment.
return dateTime?${dateTime.date}T${dateTime.time}Z:dateTime perhaps
There was a problem hiding this comment.
Agree. Changed it.
grijzea
deleted the
DWO-721-Data_Download,_does_not_download_for_complete_period
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.