fixed some small bugs #840
Conversation
added qualifier to parameter list
|
|
||
| allLocations.value = await getLocations() | ||
| locations.value = allLocations.value | ||
| selectedLocations.value = allLocations.value | ||
|
|
||
| parameters.value = await getParameters() | ||
| selectedParameters.value = parameters.value | ||
| const timeSeriesResults = await getTimeSeriesHeaders() |
There was a problem hiding this comment.
Top-level await blocks setting up the component until the request finishes, is this what we want?
In any case, since the fetches are independent, they can be executed concurrently with Promise.all or Promise.allSettled.
| const timeSeriesResults = await getTimeSeriesHeaders() | ||
| allParameters.value = await getParameters() | ||
| const parameterQualifiersHeaders: ParameterQualifiersHeader[] = [] | ||
| timeSeriesResults?.forEach((timeSeriesResult) => { |
There was a problem hiding this comment.
Could be simplified with a .map and a lodash uniqWith maybe
| function getParameterName( | ||
| parameters: TimeSeriesParameter[], | ||
| parameterQualifiersHeader: ParameterQualifiersHeader, | ||
| showParameterName: string | undefined, |
There was a problem hiding this comment.
Maybe showParameterName?: 'name' | 'short name'
| @@ -35,6 +35,16 @@ async function downloadFileWithFetch( | |||
| } | |||
| } | |||
|
|
|||
| export function filterToParams(filter: Record<string, any>): string { | |||
There was a problem hiding this comment.
If we're making a new version of filterToParams, we could also consider using the URL API for query parameters, which might be a bit nicer to work with than strings?
| @@ -0,0 +1,6 @@ | |||
| export interface DataDownloadFilter { | |||
There was a problem hiding this comment.
Should this extend a TimeSeriesFilter (or something), since we are using it on the FEWS PI time series end point?
| @@ -0,0 +1,4 @@ | |||
| export interface ParameterQualifiersHeader { | |||
There was a problem hiding this comment.
Does @deltares/fews-pi-requests not have an equivalent type? Maybe you can use Pick to extract a subset of this type, to guarantee that the types remain consistent.
added qualifier to parameter list