Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend title not updating and legend performing requests on inactive styles #836

Conversation

hvangeffen
Copy link
Collaborator

@hvangeffen hvangeffen commented Apr 24, 2024

Closes #835

Legend title would not update

image

Legend would perform a request for all previously active styles when the layerName changed

image

@hvangeffen hvangeffen self-assigned this Apr 24, 2024
@hvangeffen hvangeffen linked an issue Apr 24, 2024 that may be closed by this pull request
@hvangeffen hvangeffen force-pushed the 835-legend-performs-requests-on-inactive-styles-and-doesnt-update-title branch from 75d0cf7 to 0afdc2a Compare April 24, 2024 07:59
@hvangeffen hvangeffen changed the title Fix legend title and inactive updates, move legend utils to lib Fix legend title not updating and legend performing requests on inactive styles Apr 24, 2024
@hvangeffen hvangeffen requested a review from wkramer April 24, 2024 09:39
@wkramer wkramer force-pushed the 835-legend-performs-requests-on-inactive-styles-and-doesnt-update-title branch from 0afdc2a to 29734fd Compare April 25, 2024 12:36
@wkramer wkramer merged commit d02912f into main Apr 25, 2024
7 of 8 checks passed
@wkramer wkramer deleted the 835-legend-performs-requests-on-inactive-styles-and-doesnt-update-title branch April 25, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend performs requests on inactive styles and doesn't update title
2 participants