Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getMap requests when unit settings change #823

Merged

Conversation

hvangeffen
Copy link
Collaborator

Closes #822

@hvangeffen hvangeffen requested a review from ceesvoesenek April 18, 2024 11:51
@hvangeffen hvangeffen self-assigned this Apr 18, 2024
@hvangeffen hvangeffen linked an issue Apr 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@ceesvoesenek ceesvoesenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

function addUpdateWatcher(
watchExpression: () => unknown,
callback: (newValue: unknown) => void,
function addUpdateWatcher<T>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@wkramer wkramer merged commit 9a5d1bc into main Apr 22, 2024
7 of 8 checks passed
@wkramer wkramer deleted the 822-use-correct-system-display-units-also-for-getmap-requests branch April 22, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use correct system / display units also for getMap requests
4 participants