Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for locationId & plotId in topology nodes #709

Merged

Conversation

grijzea
Copy link
Collaborator

@grijzea grijzea commented Feb 15, 2024

No description provided.

@grijzea grijzea requested a review from ekkelenkamp February 15, 2024 14:30
Copy link
Collaborator

@ekkelenkamp ekkelenkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locationIds should also be available if plotId is set. Please extend the check with this.

Copy link
Collaborator Author

@grijzea grijzea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review comments processes

@grijzea grijzea requested a review from ekkelenkamp February 20, 2024 10:13
@grijzea
Copy link
Collaborator Author

grijzea commented Feb 20, 2024

merge after approval from Rudie

@grijzea grijzea merged commit 83bb062 into main Feb 20, 2024
7 checks passed
@grijzea grijzea deleted the FEWS-30613-PI-REST---topology/nodes---locationId-&-plotId branch February 20, 2024 11:45
@wkramer wkramer changed the title FEWS-30613 PI REST - topology/nodes? - locationId & plotId Support for locationId & plotId in topology nodes Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants