-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animated streamline layer to spatial display #696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, there is still an error for some layers. For instance for http://localhost:5173/topology/node/waves/oceanographic_waves_swan/map/oceanographic_waves_swan, when switching to 'animated', it give an "Uncaught (in promise) RangeError: offset is outside the bounds of the DataView". When going to http://localhost:5173/topology/node/currents/oceanographic_currents_cmems/map/oceanographic_currents_cmems with 'CMEMS' and 'Animated' first, and then switching to 'Oceanographic' -> 'Waves', you do get a animated layer for Swan. Something to do with the time (by comparing the two requests).
particleSize: streamlineOptions?.particleSize ?? 3, | ||
speedFactor: streamlineOptions?.speedFactor ?? 0.2, | ||
fadeAmountPerSecond: streamlineOptions?.fadeAmount ?? 0.1, | ||
particleColor: `#${streamlineOptions?.particleColor}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to set the '#' in the particleColor
? That way, a particleColor
of rgb(r,g,b)
or 'black'
would also be possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it would be, but this is a back-end problem...
cbe3c2d
to
bf22783
Compare
(Force-)pushed changes, problems appear to be fixed. |
bf22783
to
8690fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multiple getMap
request seems gone (or, at least, fewer).
However, when quickly switching between layers, I get an unexpected result:
Start at the Swan Waves animated layer:
Then, switch to WW3 and immediately switch back to Swan. I'd expect the exact layer (including times and colorrange etc) as before the switch. However, I get:
(This also still seems to trigger a double getMap
request)
8690fb9
to
e4c1680
Compare
e4c1680
to
07d7a13
Compare
No description provided.