Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display vertical profile #652

Merged
merged 28 commits into from
Feb 14, 2024
Merged

Display vertical profile #652

merged 28 commits into from
Feb 14, 2024

Conversation

hvangeffen
Copy link
Collaborator

Closes #585

@hvangeffen hvangeffen requested a review from vanmeeuwen January 24, 2024 12:40
@hvangeffen hvangeffen self-assigned this Jan 24, 2024
@hvangeffen hvangeffen linked an issue Jan 24, 2024 that may be closed by this pull request
src/components/charts/ElevationChart.vue Outdated Show resolved Hide resolved
src/components/charts/ElevationChart.vue Outdated Show resolved Hide resolved
src/components/charts/ElevationChart.vue Outdated Show resolved Hide resolved
src/components/charts/ElevationChart.vue Show resolved Hide resolved
src/components/charts/ElevationChart.vue Show resolved Hide resolved
src/components/spatialdisplay/SpatialTimeSeriesDisplay.vue Outdated Show resolved Hide resolved
@@ -30,7 +30,12 @@
<v-icon>mdi-close</v-icon>
</v-btn>
</template>
<TimeSeriesComponent :config="displayConfig" :displayType="displayType">
<TimeSeriesComponent
:config="displayConfig"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the displayConfig is an Array already

src/components/charts/ElevationChart.vue Show resolved Hide resolved
@wkramer wkramer marked this pull request as draft January 31, 2024 08:06
@wkramer
Copy link
Collaborator

wkramer commented Jan 31, 2024

Contains a number of changes that should be reverted. Do not merge as is.

Drop ca9a311
As it implemented correctly in #675

@hvangeffen hvangeffen force-pushed the 585-add-vertical-profile branch from ac02353 to 6991eac Compare February 6, 2024 13:42
@hvangeffen
Copy link
Collaborator Author

Vertical mouseOver is being added in Deltares/fews-web-oc-charts#79

@hvangeffen hvangeffen requested a review from wkramer February 8, 2024 15:41
@hvangeffen hvangeffen marked this pull request as ready for review February 8, 2024 15:41
@wkramer wkramer merged commit 8696f5c into main Feb 14, 2024
7 checks passed
@wkramer wkramer deleted the 585-add-vertical-profile branch February 14, 2024 12:24
@wkramer
Copy link
Collaborator

wkramer commented Feb 14, 2024

Still has issues with switching locations and between timeseries chart and vertical profile:
#701
#702

@wkramer wkramer changed the title 585 add vertical profile Display vertical profile Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vertical profile
2 participants