Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

547 show timeseries when clicking on location #582

Merged
merged 34 commits into from
Jan 10, 2024

Conversation

hvangeffen
Copy link
Collaborator

Closes #547

@hvangeffen hvangeffen requested a review from vanmeeuwen January 3, 2024 14:27
@hvangeffen hvangeffen self-assigned this Jan 3, 2024
@hvangeffen hvangeffen linked an issue Jan 3, 2024 that may be closed by this pull request
@hvangeffen hvangeffen force-pushed the 547-show-timeseries-when-clicking-on-location branch from d5e4180 to c86691d Compare January 3, 2024 14:32
@vanmeeuwen
Copy link
Collaborator

Changing layers doesn't stay on the same location.
For example when starting here: http://localhost:5173/topology/node/map/oceanographic_water_level_d3d/location/obs162 and then moving to the cmems, it closes the window and the location is not selected.

@hvangeffen
Copy link
Collaborator Author

Changing layers doesn't stay on the same location. For example when starting here: http://localhost:5173/topology/node/map/oceanographic_water_level_d3d/location/obs162 and then moving to the cmems, it closes the window and the location is not selected.

This is due to issues with the topology router as mentioned in #584

@vanmeeuwen vanmeeuwen requested review from wkramer and removed request for vanmeeuwen January 4, 2024 08:54
@hvangeffen
Copy link
Collaborator Author

hvangeffen commented Jan 4, 2024

This solution won't work for locations that have the same name but a different post fix:
E49d3_N29d3
E49d3_N29d3_850mb

Example case:
http://localhost:5174/map/meteo_wind_10m_gfs/location/E49d3_N29d3
http://localhost:5175/map/meteo_wind_all_levels_gfs/location/E49d3_N29d3_850mb
image
image

@wkramer wkramer force-pushed the 547-show-timeseries-when-clicking-on-location branch from 9cbd6be to 1ac709e Compare January 10, 2024 20:48
@wkramer wkramer merged commit 62ce4e0 into main Jan 10, 2024
5 checks passed
@wkramer wkramer deleted the 547-show-timeseries-when-clicking-on-location branch January 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show timeseries when clicking on location
5 participants