Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

315 vue3 authentication and authorization #316

Merged
merged 10 commits into from
Oct 16, 2023

Conversation

wkramer
Copy link
Collaborator

@wkramer wkramer commented Oct 6, 2023

No description provided.

@amarkensteijn amarkensteijn force-pushed the 315-vue3-authentication-and-authorization branch from d2c3833 to c237a76 Compare October 12, 2023 09:49
@amarkensteijn amarkensteijn force-pushed the 315-vue3-authentication-and-authorization branch from c237a76 to 3054523 Compare October 13, 2023 13:07
@amarkensteijn amarkensteijn changed the title WIP: 315 vue3 authentication and authorization 315 vue3 authentication and authorization Oct 13, 2023

const accessToken = ref('')

onBeforeMount(() => {
accessToken.value = configManager.get('VITE_MAPBOX_TOKEN')
})

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return { url } instead of { url: url }

@@ -0,0 +1,9 @@
import { authenticationManager } from '@/services/authentication/AuthenticationManager.ts'

export function transformRequestFn(controller?: AbortController) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to createTransformRequestFn

Clean-up return in transform request function
@amarkensteijn amarkensteijn merged commit 79417e4 into next Oct 16, 2023
3 checks passed
@amarkensteijn amarkensteijn deleted the 315-vue3-authentication-and-authorization branch October 16, 2023 13:13
@wkramer wkramer added the next Vue3 migration label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next Vue3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants