Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows and moduleruntimes endpoint #174

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

hvangeffen
Copy link
Collaborator

No description provided.

@hvangeffen hvangeffen linked an issue Jan 23, 2025 that may be closed by this pull request
Copy link
Collaborator

@ceesvoesenek ceesvoesenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One small comment that was not even introduced in this PR but maybe worth addressing here

@@ -1,5 +1,5 @@
import type {TimeSeriesResponse} from './response/timeseries'
import type {TaskRunsResponse} from './response/tasks'
import type {ModuleRuntimesResponse, TaskRunsResponse} from './response/tasks'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is ModuleRuntimesResponse also in ./response/tasks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tasks is a directory

@hvangeffen hvangeffen merged commit 3886d76 into main Jan 23, 2025
5 of 6 checks passed
@hvangeffen hvangeffen deleted the 173-add-workflows branch January 23, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add workflows
2 participants