cleaned up meshkernel_delete_withshp and testcase #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rqwang I accidentally merged #548 too soon due to a command line mistake and with that also made a mess of the repository history. I still have to learn how to work with external forks properly apparently. Either way, there were still some suggestions I had, but I now implemented them myself. I have simplified your testcase, so please comment if you think it does not cover what you intended anymore. Thanks again for your contribution. I also removed
include_fields=['polygons']since that is not generic. Let me know if this causes issues, we can also provideinclude_fieldsas an argument to the function an pass it onto the shapefile reading.